test: rename coalesce(x,y) alias in test_templater [NFC]
#3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuya added `coalesce()` as a built-in function with variable arity in a2a9b7d, and we want to use it with more-than-two arguments in the default `log_node` configuration in order to provide better graph node symbols for users. However, `test_templater` already defined this name as an alias, but with only two parameters; this alias now conflicts with the built-in definition and overrides it, causing the test to fail catastrophically because now the default configuration is considered invalid. Simply renaming it fixes this without invalidating the actual test case. Signed-off-by: Austin Seipp <[email protected]> Change-Id: I18593f64b9168fc334001c2ff5d49ad8d81c006d
|
Actually, I forgot that the test runner doesn't use the global config so this isn't needed; I need to get more sleep, clearly. :) I'll just leave it as part of the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yuya added
coalesce()as a built-in function with variable arity in a2a9b7d, and we want to use it with more-than-two arguments in the defaultlog_nodeconfiguration in order to provide better graph node symbols for users.However,
test_templateralready defined this name as an alias, but with only two parameters; this alias now conflicts with the built-in definition and overrides it, causing the test to fail catastrophically because now the default configuration is considered invalid.Simply renaming it fixes this without invalidating the actual test case.
Note: I pulled this out of #3381 because I realized anyone who now uses
coalesce()in theirlog_nodesetting, like I do, can no longer run the tests. So, this should just go in ASAP, in my opinion.